I was always under the assumption that trans people have a high suicide rate because their transition isn’t accepted by society, not because they were mentally ill and end up regretting it. Is there any link between them being mentally ill and because of this are therefore more susceptible to suicide?
Gender dysphoria could be categorized as mental illness, (honestly, I don't see how it is not.) However it is treatable. Also those people do not present danger nor are dysfunctional in society. There are also cases of people transitioning multiple times (I remember reading about one such example in Norway, if I remember correctly). However, making a sweeping statement brushing away gender dysphoria as a real condition and claiming they are all troubled and end up killing themselves because of their imagined problems, well I expect some hard proof for these kind of statements.
However, I also think there should be more discussion about gender dysphoria and what it constitutes and how often it is misdiagnosed. I'm pretty sure that there are people who suffer from different conditions who end up being diagnosed with gender dysphoria, or even worse self-diagnosing and self-labeling themselves as transgender. How big a percentage is of misdiagnosis, maybe it's 1%, maybe it's 50%, maybe more, maybe less. I think as a society we are charting a relatively unknown territory. And it will take years, even decades before we learn how to approach this problem.
One of the issues that I see is that treating gender dysphoria is best started early, usually some time in puberty. The sooner the transitioning starts, the better it is AFAIK. However, we are talking about teenagers. With all the stuff that's going on in their heads, insecurities, peer pressure, bullying, academic stress, generally being uncomfortable with your self, I can only imagine correctly diagnosing gender dysphoria and not just some other problem is a tremendous task.
But that is just my opinion. I've probably offended somebody if that is the case, I apologize. Everybody has the right to be happy and comfortable with themselves and nobody should be abused.